[PATCH] D93301: [flang][driver] Add support for `-c` and `-emit-obj`
    Valentin Clement via Phabricator via cfe-commits 
    cfe-commits at lists.llvm.org
       
    Tue Dec 15 11:20:02 PST 2020
    
    
  
clementval added inline comments.
================
Comment at: clang/include/clang/Driver/Options.td:4629
 
-} // let Flags = [CC1Option]
+} // let Flags = [CC1Option, NoDriverOption]
+
----------------
Is it intended to modify the SYCL options? 
================
Comment at: flang/lib/Frontend/CompilerInvocation.cpp:104
       // TODO:
       // case clang::driver::options::OPT_emit_obj:
       // case calng::driver::options::OPT_emit_llvm:
----------------
Should you remove this line since you have the case for it?
================
Comment at: flang/test/Flang-Driver/code-gen.f90:11
+! placeholder and running them leads to a driver error. This test makes sure
+! that these actions are indeed run (rather then `-c` or `-emit-obj` being
+! rejected earlier).
----------------
than instead of then? 
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93301/new/
https://reviews.llvm.org/D93301
    
    
More information about the cfe-commits
mailing list