[PATCH] D92874: [clangd] Validate clang-tidy Checks in clangd config.

Tue Dec 15 09:03:05 PST 2020

njames93 marked 2 inline comments as done.
njames93 added inline comments.

================
Comment at: clang-tools-extra/clangd/ConfigCompile.cpp:26

+#include "../clang-tidy/ClangTidyModuleRegistry.h"
 #include "CompileCommands.h"
----------------
sammccall wrote:
> This is a pretty weird place to depend on clang-tidy.
> Can we move the "is this a clang-tidy check name" function to somewhere more clang-tidy related, like `TidyProvider.h` or even `clang-tidy/ClangTidyModuleRegistry.h`? ("isRegisteredCheck")
Moving to `ClangTidyModuleRegistry.h` will still require this include.
Moving the function to `TidyProvider.h` may have a case, but as TidyProvider doesn't use the function I'm not sure it belongs in there.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92874/new/

https://reviews.llvm.org/D92874