[PATCH] D93222: [RFC][analyzer] Introduce MacroExpansionContext to libAnalysis

[Gabor Marton via Phabricator via cfe-commits]

martong added inline comments.


================
Comment at: clang/include/clang/Analysis/MacroExpansionContext.h:82
+  MacroExpansionText
+  getExpandedMacroForLocation(SourceLocation MacroExpansionLoc) const;
+
----------------
`getExpandedText` ? Since what you get back is not a macro anymore.


================
Comment at: clang/include/clang/Analysis/MacroExpansionContext.h:90
+  StringRef
+  getSubstitutedTextForLocation(SourceLocation MacroExpansionLoc) const;
+
----------------
`Substituted` is a bit ambiguous to me. What about `getOriginalText` ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93222/new/

https://reviews.llvm.org/D93222