[PATCH] D92634: [Analyzer] Diagnose signed integer overflow

Ella Ma via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 14 20:40:39 PST 2020


OikawaKirie added a comment.

I think it could be better to implement this check with a checker on `PreStmt<BinaryOperator>` and so on. And IMO, checkers have enough functionalities to report these problems.

Besides, the return value should be the exact value computed from the two integers, even unknown, rather than undefined. As the developers may overflow an integer on purpose.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92634/new/

https://reviews.llvm.org/D92634



More information about the cfe-commits mailing list