[PATCH] D91813: [PGO] verify BFI counts after loading profile data

Rong Xu via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 14 18:47:58 PST 2020


Thanks for catching that.
I messed up the commit from another patch.
Fixed in commit c36f31c.

-Rong

On Mon, Dec 14, 2020 at 4:50 PM dmajor via Phabricator <
reviews at reviews.llvm.org> wrote:

> dmajor added inline comments.
>
>
> ================
> Comment at: clang/lib/CodeGen/CGCall.cpp:1948
> +      // xur
> +      fprintf(stderr, "hihi 2\n");
> +      //      FuncAttrs.addAttribute(llvm::Attribute::Hot);
> ----------------
> This looks like something for temporary local debugging, was it
> intentional to commit it?
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D91813/new/
>
> https://reviews.llvm.org/D91813
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20201214/9b95d2d2/attachment.html>


More information about the cfe-commits mailing list