[PATCH] D91302: Handle template instantiations better in clang-tidy check

Alexander Kornienko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 14 17:24:54 PST 2020


alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.

Please fix the typo that results in a compile error.



================
Comment at: clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp:107
+                       has(expr(ignoringImpCasts(DefaultConstructor)))),
+      cxxUnresolvedConstructExpr(argummentCountIs(0)));
   // Match the object being compared.
----------------
This doesn't compile:
```
llvm-project/clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp:107:34: error: use of undeclared identifier 'argummentCountIs'; did you mean 'argumentCountIs'?
      cxxUnresolvedConstructExpr(argummentCountIs(0)));
                                 ^~~~~~~~~~~~~~~~
                                 argumentCountIs
/mnt/disks/ssd0/agent/llvm-project/clang/include/clang/ASTMatchers/ASTMatchers.h:4042:27: note: 'argumentCountIs' declared here
AST_POLYMORPHIC_MATCHER_P(argumentCountIs,
                          ^
1 error generated.
```

https://reviews.llvm.org/harbormaster/build/104600/


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91302/new/

https://reviews.llvm.org/D91302



More information about the cfe-commits mailing list