[PATCH] D91488: Consider reference, pointer, and pointer-to-membber TemplateArguments to be different if they have different types.

Richard Smith - zygoloid via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 14 15:21:13 PST 2020


rsmith added a comment.

In D91488#2451755 <https://reviews.llvm.org/D91488#2451755>, @teemperor wrote:

> I believe rsmith is in GMT-8, so I assume this won't get a fix soon and I went ahead and reverted in 22ccdb787024e954318e35fcf904fd4fa36f5679 <https://reviews.llvm.org/rG22ccdb787024e954318e35fcf904fd4fa36f5679>



In D91488#2451760 <https://reviews.llvm.org/D91488#2451760>, @davezarzycki wrote:

> Thanks. I just verified that reverting this change fixes the second stage regression and was about to commit the revert.

Thanks for the revert and verification. I saw these failures yesterday, but I incorrectly thought I saw the same failures in stage1, so they couldn't possibly be due to my change because they were compilation failures in LLVM. Oops!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91488/new/

https://reviews.llvm.org/D91488



More information about the cfe-commits mailing list