[PATCH] D93084: [VE] Optimize toolchain regression test

[Kazushi Marukawa via Phabricator via cfe-commits]

kaz7 added a comment.

Thank you for suggestions.



================
Comment at: clang/test/Driver/ve-toolchain.cpp:115
+// DEF-SAME: "-z" "max-page-size=0x4000000"
+// DEF-SAME: "crtbegin.o"
+// DEF-SAME: "-lc++" "-lc++abi" "-lunwind" "-lpthread" "-ldl"
----------------
MaskRay wrote:
> You probably should add an empty file in `basic_ve_tree` so that users who don't have a system ve toolchain (most upstream developers) have `"...basic_ve_tree/...crtbegin.o"` instead of `"crtbegin.o"`
Thank you for remainding it.  I've forgotten them.  We use crtbegin.o from compiler-rt, so I will add empty files to RESOURCE_DIR also.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93084/new/

https://reviews.llvm.org/D93084