[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

Thu Dec 10 23:22:54 PST 2020

zoecarver added a comment.

Sorry for the slow update. This patch now implements the suggested change (to "inherit" the trivial-abi attribute if there are no user-defined special members and its copy/move constructor is deleted solely because of a subobject with the attribute). Let me know what you think/if there are any other review comments.

================
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:6518
+      D->isAggregate())
+    return true;
+
----------------
I don't really love this implementation, to be honest. Mainly because it makes this function recursive and adds another special-case. 

I tried a few other implementations, but none of those worked very well. Let me know if you have alternative implementation strategies that you prefer and I'm happy to use those instead. 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92361/new/

https://reviews.llvm.org/D92361