[PATCH] D93072: Fix PR35902: incorrect alignment used for ubsan check.
Richard Smith - zygoloid via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Dec 10 15:17:26 PST 2020
rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang/lib/CodeGen/CGCXXABI.cpp:138
if (MD->getParent()->getNumVBases() == 0 || // avoid vcall in common case
MD->getParent()->hasAttr<FinalAttr>() ||
+ isThisCompleteObject(CGF.CurGD)) {
----------------
If you're so inclined, this would be better as `MD->getParent()->isEffectivelyFinal()`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93072/new/
https://reviews.llvm.org/D93072
More information about the cfe-commits
mailing list