[PATCH] D92277: [OpenCL] Refactor of targets OpenCL option settings

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl requested changes to this revision.
yaxunl added inline comments.
This revision now requires changes to proceed.


================
Comment at: clang/test/Misc/r600.languageOptsOpenCL.cl:26
 // RUN: %clang_cc1 -x cl -cl-std=CL2.0 %s -verify -triple r600-unknown-unknown -Wpedantic-core-features -DTEST_CORE_FEATURES -target-cpu turks
+// XFAIL: *
 
----------------
Pls remove XFAIL


================
Comment at: clang/test/Misc/r600.languageOptsOpenCL.cl:113
+// FIXME: this test fails because 3d image writes is core
+// feature in CL 2.0. Target should be using CL 3.0.
 #ifdef cl_khr_3d_image_writes
----------------
what's the expected behavior?

Is cl_khr_3d_image_writes to be always defined for -cl-std=CL2.0?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92277/new/

https://reviews.llvm.org/D92277