[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

Thu Dec 10 09:20:31 PST 2020

tmroeder added a comment.

In D92600#2445612 <https://reviews.llvm.org/D92600#2445612>, @martong wrote:

> I wouldn't worry much about the `ASTMerge` tests, those are mostly legacy and not actively used nowadays. (At one point we were thinking even to remove them because we could got rid of the `ASTMergeAction` which is exclusively used for testing.)
> The main test infrastructure for the ASTImporter is in the `unittests`. Those tests are exercised even with `-fdelayed-template-parsing` and with `-fms-compatibility`. So I am fine with marking the ASTMerge tests with XFAIL on windows.

Sorry for the confusion: I uploaded a change to try to fix the real test failure and there turned out to be a clang-format problem in my ASTMerge tests as well. The problems I was referring to were not in ASTMerge but rather from the unit tests in a previous diff: https://buildkite.com/llvm-project/premerge-checks/builds/19205#4f1d9b0a-16bf-401d-b07e-cceb29612fd0

Is there a way to mark unit tests as failing on a particular architecture?

The answer might not matter, because I've moved those unit tests into a different unit-test class, one that only has templates, and I hope that that means it will work correctly or be skipped correct in cases where template processing is a problem.

I haven't so far been able to get my Windows box to build LLVM (still working through some problems like atlbase.h), so I'll have to wait for the CI to tell me if x64 windows works with the diff I just uploaded: it fixes the trivial clang-format problem in the ASTMerge tests and it keeps the Structural Equivalence unit tests in the unit-test class I just mentioned.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92600/new/

https://reviews.llvm.org/D92600