[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc
Sanjay Patel via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Dec 10 08:43:04 PST 2020
spatel added a comment.
In D87188#2445506 <https://reviews.llvm.org/D87188#2445506>, @lebedev.ri wrote:
> Partial rebase (without updating test coverage)
Thanks for reducing!
If I'm seeing it correctly, the codegen looks fine - the difference is in the IR icmp predicate changing from `slt` to `ult`, and that diff appears to be correct independent of whether or not we use the abs intrinsic:
https://alive2.llvm.org/ce/z/VDDqBj
So either the source/test has an incorrect expectation and/or something outside of this function is wrong?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87188/new/
https://reviews.llvm.org/D87188
More information about the cfe-commits
mailing list