[PATCH] D92531: Reapply "Frontend: Sink named pipe logic from CompilerInstance down to FileManager"

[Jan Svoboda via Phabricator via cfe-commits]

jansvoboda11 added a comment.

Left one question.



================
Comment at: clang/lib/Basic/SourceManager.cpp:567
+  if (IR.ContentsEntry->isNamedPipe())
+    (void)IR.getBufferOrNone(Diag, getFileManager(), SourceLocation());
+
----------------
What's the reason behind duplicating the logic here instead of calling `createFileID` with `const FileEntry *SourceFile`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92531/new/

https://reviews.llvm.org/D92531