[PATCH] D92179: [clang-tidy] Catch more unwanted implicit conversions in performance-implicit-conversion-in-loop

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/performance/PerformanceTidyModule.cpp:39
+    CheckFactories.registerCheck<ImplicitConversionCheck>(
+        "performance-implicit-conversion");
     CheckFactories.registerCheck<InefficientAlgorithmCheck>(
----------------
This check has been around since at least 2016 -- are we sure we want to rename it? @alexfh -- is this a case where we should leave the old check name as an alias?

Also, as we generalize the check, it starts to be a question of whether this should be in the frontend under one of the  `-Wconversion` flags (or a new one).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92179/new/

https://reviews.llvm.org/D92179