[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

Martin Storsjö via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 10 05:00:34 PST 2020


mstorsjo added a comment.

In D87188#2445414 <https://reviews.llvm.org/D87188#2445414>, @lebedev.ri wrote:

> @mstorsjo please can you be more specific what kind of tests are starting to fail?
> Do those tests just check that the code compiled into an identical assembly?

No, it's video/audio decoding tests, and after that change specific reference input samples produce a different output hash than before.

I can retry the change (I see that the patch is recently rebased and hopefully still should apply on the latest main version) soon and see if I can pinpoint what's going wrong any closer than before.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87188/new/

https://reviews.llvm.org/D87188



More information about the cfe-commits mailing list