[PATCH] D92220: [clangd] Add support for static fields in rename

Kirill Bobyrev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 10 04:45:52 PST 2020


kbobyrev added inline comments.


================
Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:630
       )cpp",
+      R"cpp(
+        template <typename T, typename U> struct Foo { static T Variable; };
----------------
hokein wrote:
> hmm, looks like these two tests are already working at head (without the patch).
You're right, thanks for spotting it 😆 I'm quite confused, though, I was pretty sure it didn't work before. Maybe I did something wrong, I don't know.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92220/new/

https://reviews.llvm.org/D92220



More information about the cfe-commits mailing list