[PATCH] D92788: [clangd] NFC: Use SmallVector<T> where possible
Kirill Bobyrev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Dec 10 04:37:53 PST 2020
kbobyrev added inline comments.
================
Comment at: clang-tools-extra/clangd/unittests/TestTU.cpp:190
const NamedDecl &findDecl(ParsedAST &AST, llvm::StringRef QName) {
- llvm::SmallVector<llvm::StringRef, 4> Components;
+ llvm::SmallVector<llvm::StringRef> Components;
QName.split(Components, "::");
----------------
kbobyrev wrote:
> kbobyrev wrote:
> > njames93 wrote:
> > > A follow up refractor, this doesn't strictly need to be stored in a vector.
> > Could you please elaborate? I don't really understand this comment.
> (D92986 for context)
sigh, sorry, I forgot to remove it before pushing :(
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92788/new/
https://reviews.llvm.org/D92788
More information about the cfe-commits
mailing list