[PATCH] D91442: [clang][Driver] Handle risvc in Baremetal.cpp.

Thu Dec 10 04:09:05 PST 2020

abidh added a comment.

In D91442#2444399 <https://reviews.llvm.org/D91442#2444399>, @MaskRay wrote:

> This change has been failing on my machine for the past two weeks.
>
> `riscv32-toolchain-extra.c` and `riscv64-toolchain-extra.c` are not hermit. I have installed `/usr/lib/gcc-cross/riscv64-linux-gnu/10` (gcc-10-riscv64-linux-gnu and its dependencies) on my machine and the test will find some directories relative to `/usr/lib/gcc-cross/riscv64-linux-gnu/10`. I think `--sysroot` is required for such tests.
>
> `%T` is a deprecated lit feature. Please do something like `rm -rf %t; mkdir %t` instead.

Hi MaskRay,
Thanks for reporting this issue. I don't fully understand how test is finding directories relative to some other location. But I have opened https://reviews.llvm.org/D93023 to replace %T with %t as you suggested. Please have a look and see if this fixes your issue.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91442/new/

https://reviews.llvm.org/D91442