[PATCH] D92969: [AST] Fix a constexpr-evaluator crash on error-dependent returnstmt.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 10 00:34:55 PST 2020


sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/lib/AST/ExprConstant.cpp:5147
+      EvaluateDependentExpr(RetExpr, Info);
+      return ESR_Failed;
+    }
----------------
this deserves a comment: // We know we returned, but we don't know what the value is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92969/new/

https://reviews.llvm.org/D92969



More information about the cfe-commits mailing list