[PATCH] D93008: [clang][cli] Do not marshall only CC1Option flags in BoolOption

[Jan Svoboda via Phabricator via cfe-commits]

jansvoboda11 created this revision.
jansvoboda11 added reviewers: dexonsmith, Bigcheese.
Herald added a subscriber: dang.
jansvoboda11 requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.

We cannot be sure whether a flag is CC1Option inside the definition of BoolOption. This occurs when CC1Option is added like so:

  let Flags = [CC1Option] in {
    defm xxx : BoolOption<...>;
  }

because the `let yyy in {...}` is applied after all the xxx record is fully declared.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D93008

Files:
  clang/include/clang/Driver/Options.td
  clang/lib/Frontend/CompilerInvocation.cpp
  clang/unittests/Frontend/CompilerInvocationTest.cpp
  llvm/include/llvm/Option/OptParser.td

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D93008.310782.patch
Type: text/x-patch
Size: 7881 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20201210/4bfd7dc4/attachment.bin>