[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

Bruno Cardoso Lopes via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 9 23:01:11 PST 2020


bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.

LGTM, it would be great if someone else stamps this too, in case I missed something.



================
Comment at: clang/include/clang/Driver/Options.td:164
+def m_m68k_Features_Group: OptionGroup<"<m68k features group>">,
+                             Group<m_Group>, DocName<"M68k">;
 def m_mips_Features_Group : OptionGroup<"<mips features group>">,
----------------
rengolin wrote:
> craig.topper wrote:
> > bruno wrote:
> > > Looks like this is missing `clang-format`?
> > I don't think clang-format really understands tablegen files.
> It does not. Don't clang-format table-gen files, the end result is horrendous. :)
Thanks for pointing out, thinko for "please format"


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88394/new/

https://reviews.llvm.org/D88394



More information about the cfe-commits mailing list