[PATCH] D92992: [clang-tidy] Add make_unique_for_overwrite/make_shared_for_overwrite check.

[Chris Kennelly via Phabricator via cfe-commits]

ckennelly created this revision.
ckennelly added reviewers: hokein, njames93, alexfh, aaron.ballman.
Herald added subscribers: xazax.hun, mgorny.
ckennelly requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

std::make_unique_for_overwrite and std::make_shared_for_overwrite were
introduced in C++20.

These default initialize the values, unlike std::make_unique /
std::make_shared, which value initialize.  The latter can cause
unexpected performance regressions when trivial types (such as int) are
subsequently value initialized.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D92992

Files:
  clang-tools-extra/clang-tidy/modernize/CMakeLists.txt
  clang-tools-extra/clang-tidy/modernize/MakeSharedCheck.cpp
  clang-tools-extra/clang-tidy/modernize/MakeSharedForOverwriteCheck.cpp
  clang-tools-extra/clang-tidy/modernize/MakeSharedForOverwriteCheck.h
  clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp
  clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.h
  clang-tools-extra/clang-tidy/modernize/MakeUniqueCheck.cpp
  clang-tools-extra/clang-tidy/modernize/MakeUniqueForOverwriteCheck.cpp
  clang-tools-extra/clang-tidy/modernize/MakeUniqueForOverwriteCheck.h
  clang-tools-extra/clang-tidy/modernize/ModernizeTidyModule.cpp
  clang-tools-extra/docs/ReleaseNotes.rst
  clang-tools-extra/docs/clang-tidy/checks/list.rst
  clang-tools-extra/docs/clang-tidy/checks/modernize-make-shared-for-overwrite.rst
  clang-tools-extra/docs/clang-tidy/checks/modernize-make-unique-for-overwrite.rst
  clang-tools-extra/test/clang-tidy/checkers/modernize-make-shared-for-overwrite.cpp
  clang-tools-extra/test/clang-tidy/checkers/modernize-make-unique-for-overwrite.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D92992.310746.patch
Type: text/x-patch
Size: 46639 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20201210/f3e7227d/attachment-0001.bin>