[PATCH] D92984: SourceManager: Change getOrCreateFileID API to take FileEntryRef, NFC

Duncan P. N. Exon Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 9 17:02:47 PST 2020


dexonsmith created this revision.
dexonsmith added reviewers: arphaman, jansvoboda11, JDevlieghere.
Herald added subscribers: ributzka, jfb.
dexonsmith requested review of this revision.
Herald added a project: clang.

Update `SourceManager::getOrCreateFileID` to take a `FileEntryRef` and
migrate all the callers (mostly calling
`FileManager::getOptionalFileRef`). Also drop the `FileEntry*` version
of `SourceManager::createFileID` since this was the last remaining use
of it.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D92984

Files:
  clang-tools-extra/clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp
  clang-tools-extra/clang-change-namespace/tool/ClangChangeNamespace.cpp
  clang-tools-extra/clang-move/Move.cpp
  clang-tools-extra/clang-reorder-fields/tool/ClangReorderFields.cpp
  clang-tools-extra/clang-tidy/ClangTidy.cpp
  clang/include/clang/Basic/SourceManager.h
  clang/lib/Basic/SourceManager.cpp
  clang/lib/Tooling/Core/Replacement.cpp
  clang/lib/Tooling/Refactoring.cpp
  clang/tools/clang-rename/ClangRename.cpp
  clang/unittests/Basic/SourceManagerTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D92984.310722.patch
Type: text/x-patch
Size: 12035 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20201210/93a6e12c/attachment-0001.bin>


More information about the cfe-commits mailing list