[PATCH] D85788: [Clang test] Update to allow passing extra default clang arguments in use_clang

Tue Dec 8 00:41:16 PST 2020

aqjune added a comment.
Herald added a subscriber: frasercrmck.

In D85788#2335838 <https://reviews.llvm.org/D85788#2335838>, @eugenis wrote:

> I wonder it can be avoided by
>
> - disable noundef analysis by default in cc1
> - always add -enable-noundef-analysis in the driver when invoking cc1

Would this cause more tests that use `%clang` to be updated, such as  `test/CodeGen/mips-vector-return.c`?
IIUC, the tests in this patch are okay to have their `%clang` replaced with `%clang_bin` because they are not checking function signatures.

> I don't like the %clang_bin substitution - imho it's unclear for the test authors when to use it instead of %clang, but I can't come up with a better idea.

>From a user's perspective, simply naming it as `%clang_noundef` would be clearer, IMO.
This new substitution is going to be used for the noundef checks in D81678 <https://reviews.llvm.org/D81678> only anyway.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85788/new/

https://reviews.llvm.org/D85788