[PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 7 13:04:03 PST 2020


MaskRay added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4029
+      D.Diag(diag::err_drv_argument_only_allowed_with)
+          << A->getAsString(Args) << "elf output format";
+    else
----------------
"elf output format" -> "ELF platforms"

ELF is usually capitalized. Here I think "platforms" is probably more suitable than "output format" (which I'd prefer "binary format")


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90507/new/

https://reviews.llvm.org/D90507



More information about the cfe-commits mailing list