[PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4031
+    else
+      CmdArgs.push_back("-gdwarf64");
+  }
----------------
Use `render` (see other `render` in the file)


================
Comment at: clang/test/Driver/debug-options.c:379
+//
+// RUN: %clang -### -gdwarf-5 -gdwarf64 -target x86_64-linux-gnu %s 2>&1 | FileCheck -check-prefix=GDWARF64_ON %s
+// RUN: %clang -### -gdwarf-4 -gdwarf64 -target x86_64-linux-gnu %s 2>&1 | FileCheck -check-prefix=GDWARF64_ON %s
----------------
Append `-c` to test just the compile action.

`x86_64-linux-gnu` -> `x86_64` to make it clear this is a generic ELF behavior (e.g. FreeBSD works).


================
Comment at: clang/test/Driver/debug-options.c:383
+// RUN: %clang -### -gdwarf-2 -gdwarf64 -target x86_64-linux-gnu %s 2>&1 | FileCheck -check-prefix=GDWARF64_OFF %s
+// RUN: %clang -### -gdwarf-4 -gdwarf64 -target x86_64-linux-gnu -target x86_64-linux-gnu %s 2>&1 \
+// RUN:       | FileCheck -check-prefix=GDWARF64_ON %s
----------------
Don't repeat `-target x86_64-linux-gnu`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90507/new/

https://reviews.llvm.org/D90507