[PATCH] D92728: [NFC][MSan] Round up OffsetPtr in PoisonMembersgetFieldOffset(layoutStartOffset) for current calleds is expected topoint to the first trivial field or the one which follows non-trivial.So it must be byte aligned. However this is not obvious...

Evgenii Stepanov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 7 10:20:00 PST 2020


eugenis added a comment.

Don't you want to similarly align down PoisonEnd?

But if this is something that should never happen, as your comment rightly suggests, wouldn't it be better to add an assert()?
The same in the case when PoisonSize < 0 - it should never happen.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92728/new/

https://reviews.llvm.org/D92728



More information about the cfe-commits mailing list