[PATCH] D92663: [clangd] Add hot-reload of compile_commands.json and compile_flags.txt

[Nathan James via Phabricator via cfe-commits]

njames93 added inline comments.


================
Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:712
+  //  - .clang_format and .clang-tidy
+  //  - compile_commands.json
 }
----------------
Any reason for re-specifying compile_commands.json here?


================
Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:241
+    // thread-safety guarantees, as the access to FS is not locked!
+    // For now, use the real FS, which known threadsafe (if we don't use/change
+    // working directory, which ExpandResponseFilesDatabase does not).
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92663/new/

https://reviews.llvm.org/D92663