[PATCH] D92157: [clangd] Add language metrics for recovery AST usage.
Haojian Wu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Dec 7 01:39:42 PST 2020
hokein added inline comments.
================
Comment at: clang-tools-extra/clangd/Selection.cpp:44
+ return;
+ const char *LanguageLabel = Lang.CPlusPlus ? "C++" : Lang.ObjC ? "ObjC" : "C";
static constexpr trace::Metric SelectionUsedRecovery(
----------------
sammccall wrote:
> This classifies objc++ as c++.
> Not necessarily a problem, up to you
yeah, this is my intention as we don't really care about C++ or ObjC++.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92157/new/
https://reviews.llvm.org/D92157
More information about the cfe-commits
mailing list