[PATCH] D92596: [FPEnv] Correct constrained metadata in fp16-ops-strict.c

[Melanie Blower via Phabricator via cfe-commits]

mibintc added inline comments.


================
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2992
     // floating point environment in the loop.
+//XXX true?
     llvm::BasicBlock *startBB = Builder.GetInsertBlock();
----------------
did you mean to leave this here? (blame shows the fixme comment dates from 2012)


================
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3006
 
+  CodeGenFunction::CGFPOptionsRAII FPOptsRAII(CGF, OpInfo.FPFeatures);
   SourceLocation Loc = E->getExprLoc();
----------------
What's the rule to follow about when we need to FPOptsRAII? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92596/new/

https://reviews.llvm.org/D92596