[PATCH] D92480: [llvm] Add asserts in (ThreadSafe)?RefCountedBase destructors

David Blaikie via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 4 12:33:38 PST 2020


dblaikie added inline comments.


================
Comment at: llvm/include/llvm/Support/ManagedStatic.h:25
+// that are const with no params.
+template <typename T> struct HasRetainRelease {
+private:
----------------
Are there many uses that rely on this? I don't think it's really worth all this infrastructure - compared to having it supported on an as-needed basis, such as directly in TrueMatcherImpl's ctor and dtor.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92480/new/

https://reviews.llvm.org/D92480



More information about the cfe-commits mailing list