[PATCH] D90188: Add support for attribute 'using_if_exists'

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 4 09:30:41 PST 2020


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM aside from a minor nit, thank you!



================
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:11681
+  if (isa<UnresolvedUsingIfExistsDecl>(Target) !=
+      (NonTag && isa<UnresolvedUsingIfExistsDecl>(NonTag))) {
+    if (!NonTag && !Tag)
----------------
You can use `isa_and_nonnull<>()` instead of testing for null yourself.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90188/new/

https://reviews.llvm.org/D90188



More information about the cfe-commits mailing list