[PATCH] D92642: [clangd] Fix an assertion violation in rename.

[Sam McCall via Phabricator via cfe-commits]

sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:949
 
+      {R"cpp(// disallow rename on non-normal identifiers.
+         @interface Foo {}
----------------
This case seems a little *too* special: you might consider `-(int) foo:(int)x;` or so to make it clearer why this isn't an ordinary name.

I'd also make the comment a bit more specific: "Token is an identifier, but declaration name isn't a simple identifier".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92642/new/

https://reviews.llvm.org/D92642