[PATCH] D92633: Add -f[no-]direct-access-external-data to deprecate -mpie-copy-relocations

[Sriraman Tallam via Phabricator via cfe-commits]

tmsriram added a comment.

You said : "The name -mpie-copy-relocations is misleading [1] and does not capture the idea that this option can actually apply to all of -fno-pic,-fpie, ..."

Could you please clarify why this option needs to apply to -fno-pic?  Here is what I tried with trunk clang:

extern int var;
int get() { return var; }

$ clang -S foo.c -o -
....
	movl	var, %eax
	popq	%rbp
...

With -fno-pic,  this will never need to use -mpie-copy-relocations at all, so this case is not relevant right?  Did I miss anything?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92633/new/

https://reviews.llvm.org/D92633