[PATCH] D92078: [asan] Default to -asan-use-private-alias=1
Vitaly Buka via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Dec 3 17:05:55 PST 2020
vitalybuka added a comment.
alias change is LGTM, we can try to figure-out how to roll out -fsanitize-address-use-odr-indicator
================
Comment at: compiler-rt/test/asan/TestCases/Linux/odr-vtable.cpp:5
+// RUN: %clangxx_asan -fno-rtti -DBUILD_SO1 -fPIC -shared -mllvm -asan-use-private-alias=0 %s -o %dynamiclib1
+// RUN: %clangxx_asan -fno-rtti -DBUILD_SO2 -fPIC -shared -mllvm -asan-use-private-alias=0 %s -o %dynamiclib2
// RUN: %clangxx_asan -fno-rtti %s %ld_flags_rpath_exe1 %ld_flags_rpath_exe2 -o %t
----------------
now we don't test default behavior
can you add CHECKs for alias=1 as well?
same below
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92078/new/
https://reviews.llvm.org/D92078
More information about the cfe-commits
mailing list