[PATCH] D92130: [HIP] cmath promote long double args to double
    Aaron Enye Shi via Phabricator via cfe-commits 
    cfe-commits at lists.llvm.org
       
    Thu Dec  3 15:01:19 PST 2020
    
    
  
ashi1 added a comment.
In D92130#2423801 <https://reviews.llvm.org/D92130#2423801>, @tra wrote:
> LGTM in general. Will defer to Sam as it's HIP.
>
> Nit:
>
>> long double, promote them to double, and use the fp64
>
> I'd say `long double` -> `double` qualifies as a demotion.
Thanks, I've changed the commit description to demote.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92130/new/
https://reviews.llvm.org/D92130
    
    
More information about the cfe-commits
mailing list