[PATCH] D92606: Clean up debug locations for logical-and/or expressions

[Paul Robinson via Phabricator via cfe-commits]

probinson created this revision.
probinson added reviewers: dblaikie, rnk.
probinson added a project: debug-info.
probinson requested review of this revision.
Herald added a project: clang.

Attaches a more appropriate debug location to the PHIs used for the
short-circuit evaluations, and makes logical-and and logical-or
handling consistent.  Also sets the appropriate debug location for all
scalar conversions, which incidentally does the right thing for
int-to-bool conversions in particular.

While this does tidy up the source locations emitted to IR, it doesn't
appear to make any difference in the final object file for simple
tests.  However, it should permit re-applying D91734 <https://reviews.llvm.org/D91734> and friends to
improve the debug info without exposing the regressions that prompted
the reverts in #615f63e.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D92606

Files:
  clang/lib/CodeGen/CGExprScalar.cpp
  clang/test/CodeGen/debug-info-inline-for.c
  clang/test/CodeGen/debug-info-land-lor.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D92606.309360.patch
Type: text/x-patch
Size: 4902 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20201203/b5f82ae3/attachment.bin>