[PATCH] D92427: [OPENMP51] Add present modifier in defaultmap clause

[Alexey Bataev via Phabricator via cfe-commits]

ABataev added inline comments.


================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:3490
+                OMPC_MAP_MODIFIER_present);
+            ImplicitMapModifierLoc[ClauseKind].push_back(SourceLocation());
+          }
----------------
cchen wrote:
> ABataev wrote:
> > Why need to add an empty `SourceLocation`?
> I'm doing this since there is no actual location for present modifier. Maybe I should just pass llvm::None to ActOnOpenMPMapClause.
Could you store the original location of the `present` modifier and add a real source location rather. Better to use correct locations when possible, it may help with the debug info emission


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92427/new/

https://reviews.llvm.org/D92427