[PATCH] D92573: [clang] Add a C++17 deduction guide testcase.

Adam Czachorowski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 3 07:20:38 PST 2020


adamcz accepted this revision.
adamcz added a comment.
This revision is now accepted and ready to land.

Thanks, adding this test is a very good idea.



================
Comment at: clang/test/PCH/cxx17-deduction-guide-decl.cpp:16
+
+// Class template argument deduction
+template <typename T>
----------------
You can drop these 3 lines, they're not needed for the crash repro. Also, c-tor doesn't have to be explicit. Probably best to keep the code as short as possible.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92573/new/

https://reviews.llvm.org/D92573



More information about the cfe-commits mailing list