[PATCH] D92439: [CLANG] Fix missing error for use of 128-bit integer inside SPIR64 device code.

Wed Dec 2 16:30:11 PST 2020

jyu2 added a comment.

In D92439#2429511 <https://reviews.llvm.org/D92439#2429511>, @jdoerfert wrote:

> Still unsure if we should also error out for NVPTX but that is a different story. Looks OK from my side, assuming you address the earlier comment.

With this change if NVPTX need diagnostic for  use of 128-bit integer, adding "bool hasInt128Type() const override { return false; }" in NVPTX.h is all needed.

> Maybe someone else should accept though.

Do you have suggestion whom I may contact for acceptance?  We have customer needs for this...   Thank you in advance. :-)

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92439/new/

https://reviews.llvm.org/D92439