[PATCH] D92512: ADT: Change AlignedCharArrayUnion to an alias of std::aligned_union_t, NFC

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 2 15:09:26 PST 2020


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

Looks good to me.



================
Comment at: llvm/include/llvm/Support/ErrorOr.h:256-257
   union {
     AlignedCharArrayUnion<storage_type> TStorage;
     AlignedCharArrayUnion<std::error_code> ErrorStorage;
   };
----------------
This union of unions of one type seems silly. I think there can be as single `Storage` field. Anyway, fixing this is not in scope for this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92512/new/

https://reviews.llvm.org/D92512



More information about the cfe-commits mailing list