[PATCH] D91789: [clang-tidy] find/fix unneeded trailing semicolons in macros

Nick Desaulniers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 2 11:39:00 PST 2020


nickdesaulniers added a comment.

Hi @trixirt , thanks for the follow up.  I think the lint feedback about qualifying `auto` with pointers where applicable would be nice to have. Please make those suggested changes.

Should https://reviews.llvm.org/D90180 be abandoned in favor of this patch?

Would you mind editing the description/commit message of this patch to describe to kernel developers how they're expected to run this clang tidy check such that the fixits are applied?



================
Comment at: clang-tools-extra/clang-tidy/linuxkernel/ExtraSemiCheck.h:20
+
+enum ExtraSemiFixerKind { ESFK_None, ESFK_Switch, ESFK_TrailingMacro };
+class ExtraSemiCheck : public ClangTidyCheck {
----------------
Can this enum be declared within the class scope of `ExtraSemiCheck` rather than outside of it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91789/new/

https://reviews.llvm.org/D91789



More information about the cfe-commits mailing list