[PATCH] D80450: [CUDA][HIP] Fix HD function resolution

Artem Belevich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 2 10:12:07 PST 2020


tra added a comment.

In D80450#2428631 <https://reviews.llvm.org/D80450#2428631>, @yaxunl wrote:

>> Also,  naming. `-ffix-overload-resolution` is rather non-specific. I didn't mean to use it literally. The problem is that I can't think of a good descriptive name for what we do here. `-fgpu-fix-wrong-side-overloads` ? Something else?
>
> How about `-fgpu-exclude-wrong-side-overloads`? Since what this patch does is always excluding wrong side overloads whereas previously only excluding wrong side overloads if there are same side overloads.

SGTM. Maybe, also make it hidden. I don't think it's useful for the end users.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80450/new/

https://reviews.llvm.org/D80450



More information about the cfe-commits mailing list