[PATCH] D92041: [clangd] Add hover info for `this` expr

xndcn via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 2 10:00:44 PST 2020


xndcn updated this revision to Diff 308994.
xndcn added a comment.

`getHoverInfo(CXXThisExpr->getType()->getPointeeType(), ...)` does not output namespace scope and template parameters without specialization:
F14499632: Pointee.png <https://reviews.llvm.org/F14499632>

while `getHoverInfo(CXXThisExpr->getType(), ...)` looks weird with partial specialization:
F14499662: QualType.png <https://reviews.llvm.org/F14499662>

So I did some mix here...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92041/new/

https://reviews.llvm.org/D92041

Files:
  clang-tools-extra/clangd/Hover.cpp
  clang-tools-extra/clangd/unittests/HoverTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D92041.308994.patch
Type: text/x-patch
Size: 3368 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20201202/5b00037f/attachment-0001.bin>


More information about the cfe-commits mailing list