[PATCH] D92001: [ubsan] Fix crash on __builtin_assume_aligned

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 2 09:51:57 PST 2020


lebedev.ri added inline comments.


================
Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:2524
   // defined.
-  if (Ty->getPointeeType().isVolatileQualified())
+  if (!Ty->getPointeeType().isNull() && Ty->getPointeeType().isVolatileQualified())
     return;
----------------
vsk wrote:
> Is the pointee type associated with a PointerType QualType ever supposed to be null? I wonder why this happens, and whether it can cause problems in other places.
Basically, we can't just use `getPointeeType()` here, but i'm not sure what should be used instead.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92001/new/

https://reviews.llvm.org/D92001



More information about the cfe-commits mailing list