[PATCH] D87216: [NewPM] Support --print-before/after in NPM

Arthur Eubanks via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 2 09:46:52 PST 2020


aeubanks added a comment.

In D87216#2428359 <https://reviews.llvm.org/D87216#2428359>, @jamieschmeiser wrote:

> I see you have made the requested changes (nit: clang-tidy complained about the capitalization of the function) but why are there so many other, unrelated changes shown?  Is there a problem with the patch?

Fixed the capitalization.

Do you mean moving around options/definitions into PrintPasses.cpp? The declarations/definitions don't really have a good place to live right now, I moved them to their own file to make it cleaner.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87216/new/

https://reviews.llvm.org/D87216



More information about the cfe-commits mailing list