[PATCH] D92487: [AArch64][Driver][SVE] Push missing SVE feature error from driver to frontend

Sander de Smalen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 2 09:02:50 PST 2020


sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.

Other than the nit, LGTM.



================
Comment at: clang/lib/Sema/SemaType.cpp:7789
+    S.Diag(Attr.getLoc(), diag::err_attribute_unsupported)
+        << Attr << "'neon' or 'mve' feature flag";
     Attr.setInvalid();
----------------
nit: s/ feature flag//
(otherwise, for this case it should be 'feature flags' and the case below would need 'the ' in front of it, to read nicely).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92487/new/

https://reviews.llvm.org/D92487



More information about the cfe-commits mailing list