[PATCH] D92354: [clang] add a new `swift_attr` attribute

Erik Pilkington via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 2 08:14:28 PST 2020


erik.pilkington added a comment.

Do we need to add APINotes support for this?



================
Comment at: clang/include/clang/Basic/Attr.td:2155
+  let Args = [StringArgument<"Attribute">];
+  let Documentation = [SwiftAttrDocs];
+}
----------------
Should we limit this to appear on certain subjects? Presumably the swift importer is only going to look for this in certain places, so I think it makes sense to call out places where it'll be ignored in clang. WDYT?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92354/new/

https://reviews.llvm.org/D92354



More information about the cfe-commits mailing list