[PATCH] D89987: [analyzer] [NFC] Rename SymbolRef to SymExprRef
Denys Petrov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Dec 2 05:41:49 PST 2020
ASDenysPetrov added a comment.
@steakhal
> Losing **git blame** would have a signifficant impact in deed, however we always have the option to add the renaming commit to the `.git-blame-ignore-revs`.
Using this git feature I can see no more obstacles to implement the renaming. Moreover LLVM repo already has similar instances in `.git-blame-ignore-revs`.
> To achieve that, we should probably have a better reason behind it besides simply //renaming// stuff.
Untill we start this process we will mix this up every time. So, I would start the renaming with the `blame-ignore` marking.
Let's answer the question: What bad things can occur if we rename `SymbolRef` to `SymExprRef`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89987/new/
https://reviews.llvm.org/D89987
More information about the cfe-commits
mailing list